Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore annotation names #1604

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Ignore annotation names #1604

merged 1 commit into from
Aug 4, 2023
+27 −2

Conversation

gemal
Copy link
Contributor

@gemal gemal commented Aug 4, 2023

fixes #1603

@gemal gemal requested a review from kukulich August 4, 2023 10:59
kukulich
kukulich requested changes Aug 4, 2023
View reviewed changes
doc/namespaces.md Outdated Show resolved Hide resolved
@gemal gemal requested a review from kukulich August 4, 2023 11:03
kukulich
kukulich requested changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@kukulich kukulich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash it to one commit and change the commit message like this: 3200c0b

@gemal
Copy link
Contributor Author

gemal commented Aug 4, 2023

Please squash it to one commit and change the commit message like this: 3200c0b

not sure how to do this. I'm using github desktop as a client

@gemal
Copy link
Contributor Author

gemal commented Aug 4, 2023

Please squash it to one commit and change the commit message like this: 3200c0b

not sure how to do this. I'm using github desktop as a client

better now?

@kukulich kukulich merged commit 4d19fe3 into slevomat:master Aug 4, 2023
35 checks passed
@gemal
Copy link
Contributor Author

gemal commented Aug 4, 2023

@kukulich Thank you for nice and fast guide for me to contribute. An excellent example of open source!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kukulich kukulich kukulich requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False positive for NonFullyQualifiedClassName
2 participants
@gemal @kukulich